Optimize #1103
Merged
Optimize #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerams
commented
May 12, 2025
src/Fabulous/Array.fs
Outdated
| @@ -49,7 +49,7 @@ module ArraySlice = | |||
| module Array = | |||
| let inline appendOne (v: 'v) (arr: 'v array) = | |||
| let res = Array.zeroCreate(arr.Length + 1) | |||
| res[.. arr.Length - 1] <- arr | |||
| arr.CopyTo (res.AsSpan ()) | |||
There was a problem hiding this comment.
This is several times faster.
kerams
commented
May 12, 2025
| @@ -89,7 +89,7 @@ module StackAllocatedCollections = | |||
| [<NoComparison; NoEquality>] | |||
| type private Part<'v> = | |||
| | Empty | |||
| | Filled of struct (Items<'v> * Part<'v>) | |||
| | Filled of Items<'v> * Part<'v> | |||
There was a problem hiding this comment.
Removes indirection.
kerams
commented
May 12, 2025
Comment on lines
-261
to
+262
| | Few of data: struct (Size * 'v * 'v * 'v) | ||
| | Many of arr: 'v array | ||
| | Few of data: Size * 'v * 'v * 'v |
There was a problem hiding this comment.
Removes indirection and decreases total DU struct size with some type parameters (48 to 40 bytes for string).
kerams
commented
May 12, 2025
| | Added of added: uint16 | ||
| | Removed of removed: uint16 | ||
| | Changed of changed: uint16 | ||
|
|
||
| | Added of value: uint16 | ||
| | Removed of value: uint16 | ||
| | Changed of value: uint16 |
There was a problem hiding this comment.
Merges fields and reduces struct size from 12 to 8 bytes.
edgarfgp
approved these changes
May 12, 2025
|
Thanks @kerams |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.