Skip to content

feat: extend the existingJavaTypes to support use of existing enumerations. #7046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Apr 30, 2025

Description

See #7045

Extends the existing existingJavaTypes of the java-generator-maven-plugin' to allow the generated code to refer to existing enumerations.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this effort @k-wall !
Looks good apart from a single detail 🙂

@k-wall k-wall force-pushed the iss_7045 branch 2 times, most recently from ffc37ee to 2447e63 Compare April 30, 2025 09:57
@k-wall
Copy link
Contributor Author

k-wall commented Apr 30, 2025

I don't think the test failure showing in CI relates to my chnage.

 Errors: 
Error:    JdkHttpLoggingInterceptorTest>AbstractHttpLoggingInterceptorTest.httpLargeResponseBodyLogged:205 » Execution java.net.ProtocolException: protocol error: Frame type(114) length(6776096) exceeds MAX_FRAME_SIZE(16384)
[INFO]

Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors in CI are spurious, thanks a lot for the effort, LGTM 👍

@k-wall
Copy link
Contributor Author

k-wall commented May 2, 2025

Not sure if the Quality Gate being B means this cannot be merged. I looked at the issues being flagged by Sonar:

  • java:S107 - constructor parameter count rule doesn't seem to be well adhered to by the project. In this case, there doesn't appear to be a reasonable alternative to adding the pkg parameter.
  • java:S6355 - The project doesn't seem to use the Deprecated since/forRemoval parameters

the remaining issues relate to the new deprecated method.

I don't think there is anything to action. If the maintainers think different, I'll happily oblige.

Copy link

sonarqubecloud bot commented May 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants