-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: extend the existingJavaTypes to support use of existing enumerations. #7046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this effort @k-wall !
Looks good apart from a single detail 🙂
java-generator/core/src/main/java/io/fabric8/java/generator/nodes/JEnum.java
Show resolved
Hide resolved
ffc37ee
to
2447e63
Compare
I don't think the test failure showing in CI relates to my chnage.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errors in CI are spurious, thanks a lot for the effort, LGTM 👍
Not sure if the Quality Gate being B means this cannot be merged. I looked at the issues being flagged by Sonar:
the remaining issues relate to the new deprecated method. I don't think there is anything to action. If the maintainers think different, I'll happily oblige. |
…tions fabric8io#7045 Signed-off-by: Keith Wall <[email protected]>
Signed-off-by: Keith Wall <[email protected]>
|
Description
See #7045
Extends the existing
existingJavaTypes
of the java-generator-maven-plugin' to allow the generated code to refer to existing enumerations.Type of change
test, version modification, documentation, etc.)
Checklist