Skip to content

Added german translation #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Added german translation #222

merged 6 commits into from
Dec 5, 2022

Conversation

derzinn
Copy link
Contributor

@derzinn derzinn commented Dec 4, 2022

Adds German translation. Translated by myself (native speaker).

@fabiocaccamo Thank you for your great work on this project!

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Base: 94.64% // Head: 94.64% // No change to project coverage 👍

Coverage data is based on head (32dd0d1) compared to base (63977a4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          36       36           
  Lines         392      392           
=======================================
  Hits          371      371           
  Misses         21       21           
Flag Coverage Δ
unittests 94.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@merwok
Copy link
Contributor

merwok commented Dec 4, 2022

There is a list of languages to update in tests/settings.py + one test

@derzinn
Copy link
Contributor Author

derzinn commented Dec 5, 2022

"Filter" comes already from the Django admin catalog. In all other language files, this ID is flagged as fuzzy because it changes from "List Filter" to "Filter" and will be ignored by compilemessages.

@merwok What do you recommend?

@fabiocaccamo fabiocaccamo merged commit 14634aa into fabiocaccamo:master Dec 5, 2022
@fabiocaccamo
Copy link
Owner

@derzinn thank you for this PR!

@merwok
Copy link
Contributor

merwok commented Dec 5, 2022

"Filter" comes already from the Django admin catalog.

I realized that after and deleted my comment!
I forgot to add the translators note when I copied some templates from django.

In all other language files, this ID is flagged as fuzzy because it changes from "List Filter" to "Filter"

These msgids should be fixed (remove the fuzzy marker and incorrect suggestion)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants