Inconsistant type for sourceLabels and detectorLabels

[Edouard2laire]

Hello,

It seems there is an issue with the examples in 'Simple_Probe.snirf' with sourceLabels being a cell instead of a string array as the other labels :

jnirs = loadsnirf('neuro_run01.snirf');
class(jnirs.nirs.probe.detectorLabels) %'string'
class(jnirs.nirs.probe.sourceLabels) % 'string'
 

jnirs = loadsnirf('Simple_Probe.snirf');
class(jnirs.nirs.probe.detectorLabels) %'string'
class(jnirs.nirs.probe.sourceLabels) %'cell'

Regards,
Edoaurd

[Edouard2laire]

any update @fangq ?

Edit: I fixed our loader here but i guess it would be easier to always have string arrays: brainstorm-tools/brainstorm3@db134e4

Edit: i think the issue is here: https://github.com/fNIRS/snirf-samples/blob/master/basic/Simple_Probe.jnirs#L1372
i think it should be : "sourceLabels": [ "S1" ]

[fangq]

@Edouard2laire, the reported issue has been fixed with a combination of easyh5 NeuroJSON/easyh5@e04da0c and jsnirfy commit NeuroJSON/jsnirfy@f0caf85

I also updated the snirf-samples test scripts and added a round-trip test, it shows that jsnirf can reproduce valid .snirf files,. which can reproduce the source jsnirf file.

https://github.com/fNIRS/snirf-samples/blob/master/basic/updatesnirffromsrc.m
https://github.com/fNIRS/snirf-samples/blob/master/basic/roundtriptest.m

please update easyh5, jsnirfy and snirf-samples repos and see if there are additional issues.