Skip to content

Rename _putchar() #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eyalroz opened this issue Nov 8, 2021 · 0 comments
Closed

Rename _putchar() #55

eyalroz opened this issue Nov 8, 2021 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Nov 8, 2021

According to the C2X standard draft and the glibc documentation, we should avoid using identifiers starting with an underscore (_) visible at file scope. So, let's avoid that by renaming our _putchar() into putchar().
@eyalroz eyalroz added the task label Nov 8, 2021
@eyalroz eyalroz self-assigned this Nov 8, 2021
eyalroz added a commit that referenced this issue Nov 8, 2021
@eyalroz
Fix #55: Renamed _putchar() -> putchar_(), so we now have no more…
ba87ce7 
… identifiers at file scope starting with `_`.
@eyalroz eyalroz added the resolved-on-develop A changeset fixing this issue has been commiutted to the development branch label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz