Skip to content

Test suite implicitly assumes long long support #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eyalroz opened this issue Sep 22, 2021 · 0 comments
Closed

Test suite implicitly assumes long long support #49

eyalroz opened this issue Sep 22, 2021 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch testing Only relevant to the testing programs rather than the main code itself

Comments

@eyalroz
Copy link
Owner

eyalroz commented Sep 22, 2021

If we disable support for long long specifiers (e.g. "%llu"), a bunch of test suite checks fail. These should mostly be removed, with one or a few checks for unsupported specifier being properly ignored.

This also relates to #45 , since some of the checks may involve pointers, and there we might actually have a correctness issue when long long support is turned off.
@eyalroz eyalroz self-assigned this Sep 22, 2021
@eyalroz eyalroz added testing Only relevant to the testing programs rather than the main code itself resolved-on-develop A changeset fixing this issue has been commiutted to the development branch labels Sep 22, 2021
eyalroz added a commit that referenced this issue Sep 22, 2021
@eyalroz
Fixes #49: All test suite checks using long-long specifiers are now g…
3d952c0 
…uarded by `#if PRINTF_SUPPORT_LONG_LONG`, and in a few configurations, all checks pass both with and without that flag turned on. Any other failures can get their own issues...
eyalroz added a commit that referenced this issue Sep 27, 2021
@eyalroz
Fixes #49: All test suite checks using long-long specifiers are now g…
913a09e 
…uarded by `#if PRINTF_SUPPORT_LONG_LONG`, and in a few configurations, all checks pass both with and without that flag turned on. Any other failures can get their own issues...
@eyalroz eyalroz closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch testing Only relevant to the testing programs rather than the main code itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz