Skip to content
This repository was archived by the owner on Jul 26, 2022. It is now read-only.

Support isBinary: true for GCP secrets manager #352

Closed
pmuir opened this issue Apr 21, 2020 · 0 comments · Fixed by #353
Closed

Support isBinary: true for GCP secrets manager #352

pmuir opened this issue Apr 21, 2020 · 0 comments · Fixed by #353

Comments

@pmuir
Copy link
Contributor

pmuir commented Apr 21, 2020

This is useful if you have a secret (for example a JSON file) that is already base64 encoded in GCP secrets manager.

With this I can then create a secret that looks like

  credentials.json: |
  { ...}

which is needed e.g. when writing out GCP SA files.

pmuir added a commit to pmuir/kubernetes-external-secrets that referenced this issue Apr 21, 2020
pmuir added a commit to pmuir/kubernetes-external-secrets that referenced this issue Apr 21, 2020
pmuir added a commit to pmuir/kubernetes-external-secrets that referenced this issue Apr 21, 2020
pmuir added a commit to pmuir/kubernetes-external-secrets that referenced this issue Apr 23, 2020
Flydiverny added a commit that referenced this issue Apr 23, 2020
* feat: support isBinary for GCP

Fixes #352

Signed-off-by: Pete Muir <[email protected]>

* chore: jsdoc

Co-authored-by: Markus Maga <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant