Skip to content

chore: Update testdata-w3c-json-form #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2019

Conversation

Trott
Copy link
Contributor

@Trott Trott commented Jul 5, 2019

Version 1.0.0 of testdata-w3c-json-form contains a correction to the
test data. Without the correction (of the bottle-on-wall type from an
array of numbers to an array of strings), it is possible that tests will
break in Node.js 13.0.0 or a future release.

Version 1.0.0 of testdata-w3c-json-form contains a correction to the
test data. Without the correction (of the bottle-on-wall type from an
array of numbers to an array of strings), it is possible that tests will
break in Node.js 13.0.0 or a future release.
@Trott
Copy link
Contributor Author

Trott commented Jul 5, 2019

(By the way, the "may break in a future Node.js version" comes from nodejs/node#28011. There's an excellent chance that change won't land, but there's a non-zero chance it will, and I hope it will, so... this will make sure it doesn't break multer tests.)

@Trott
Copy link
Contributor Author

Trott commented Jul 6, 2019

Travis is green even though the widget says yellow/in-progress.
¯\(ツ)

@LinusU
Copy link
Member

LinusU commented Jul 7, 2019

Travis is green even the widget says yellow/in-progress.

Tried restarting one of the builds...

@LinusU LinusU merged commit 02ad63c into expressjs:master Jul 7, 2019
@LinusU
Copy link
Member

LinusU commented Jul 7, 2019

Thanks!

@Trott
Copy link
Contributor Author

Trott commented Jul 16, 2019

Any chance of a patch release getting pushed with this change? I'd like to get nodejs/node#28011 landed in Node.js but multer tests will fail until this change is in a release, and multer is one of the npm modules that gets tested in the tests for breaking changes in Node.js core.

@LinusU
Copy link
Member

LinusU commented Jul 16, 2019

Hmm, I usually don't do patch releases with just a bumped dev-dependency since it wouldn't change anything for the consumers of the library, but sure thing 👍

@LinusU
Copy link
Member

LinusU commented Jul 16, 2019

[email protected] published :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants