feat: add feeds for the blog and vulnerabilities #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rowanmanning
commented
Apr 11, 2025
bjohansebas
reviewed
Apr 12, 2025
There was a problem hiding this comment.
Overall, everything looks good, @rowanmanning thanks for working on this.
wesleytodd
approved these changes
Apr 14, 2025
This adds two new feeds to the site: `feed.xml` includes all blog posts, and `vulnerabilities.xml` includes all posts tagged with `vulnerabilities`. Resolves expressjs#1763
Jekyll expects tags to be space-delimited, using commas results in the tags themselves containing a comma. See docs: https://jekyllrb.com/docs/posts/#tags Fixing this allows us to stop working around the trailing commas.
|
@rowanmanning Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new feeds to the site:
feed.xmlincludes all blog posts, andvulnerabilities.xmlincludes all posts tagged withvulnerabilities.You can validate the feeds via the W3C Feed Validation Service. I also tried subscribing via Feedbin and all the posts appear as expected.
Resolves #1763