perf(request): move static getters to prototype for ~2× throughput #6619
+20
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Express currently uses
Object.defineProperty
to attach request properties likeprotocol
,secure
,ip
,ips
,hostname
, andsubdomains
on each request instance. While functional, this approach redefines these properties per request, which adds unnecessary overhead in high-load scenarios.This PR moves those properties to
http.IncomingMessage.prototype
so they’re defined once and reused across all requests.Why This Change
Impact
Benchmark (Node 20, 1024c)
Before: 6,572 req/s
After: 12,931 req/s
→ That’s about +96% performance boost in real benchmarks.
Reference
Closes: expressjs/perf-wg#15