Skip to content

remove once npm package #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

bhavya3024
Copy link
Contributor

@bhavya3024 bhavya3024 commented Jun 3, 2025

Do we really need it ? as we can manually implement it

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this dep doesn't achieve anything because it is also used in other libraries that ship with express. We would need to duplicate this code into all of them.

@jonchurch
Copy link
Member

Thanks for the PR! The change is valid, and the implementation looks fine. That said, I'd stick with the current use of once.

It was added intentionally in #3216 as a minimal, well-scoped alternative to ee-first. I prefer to keep small, purpose-built dependencies like this when they clearly express intent and don’t add meaningful overhead.

Inlining this logic doesn’t materially improve clarity or reduce maintenance cost, so I'd opt to keep it as is.

@ctcpip
Copy link
Member

ctcpip commented Jun 4, 2025

agree with comments. @bhavya3024 thank you for your contribution. 🙏 it can be frustrating to spend time implementing and testing something that does not get accepted. in future, it would be helpful to first create a discussion for a proposed change like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants