Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove promise support check from tests #6148

Merged
merged 1 commit into from
Nov 12, 2024
Merged

cleanup: remove promise support check from tests #6148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/app.route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
var express = require('../');
var request = require('supertest');

var describePromises = global.Promise ? describe : describe.skip

describe('app.route', function(){
it('should return a new route', function(done){
var app = express();
Expand Down Expand Up @@ -64,7 +62,7 @@ describe('app.route', function(){
.expect(404, done);
});

describePromises('promise support', function () {
describe('promise support', function () {
it('should pass rejected promise value', function (done) {
var app = express()
var route = app.route('/foo')
Expand Down
3 changes: 1 addition & 2 deletions test/app.router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ var express = require('../')
, assert = require('assert')
, methods = require('methods');

var describePromises = global.Promise ? describe : describe.skip
var shouldSkipQuery = require('./support/utils').shouldSkipQuery

describe('app.router', function(){
Expand Down Expand Up @@ -963,7 +962,7 @@ describe('app.router', function(){
})
})

describePromises('promise support', function () {
describe('promise support', function () {
it('should pass rejected promise value', function (done) {
var app = express()
var router = new express.Router()
Expand Down
Loading