-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy on using caret (^) or tilde (~) with dependencies #290
Conversation
bb4078a
to
f8b639b
Compare
Signed-off-by: Ulises Gascon <[email protected]>
f8b639b
to
778a16f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR I think we should try to be high trust and good examples of OSS by treating all dependencies the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @UlisesGascon is alright with the suggestions to use ^
for all, I tried to make change suggestions to everywhere I noticed where it was referenced. Personally I think the conservative approach used in earlier days is not necessary anymore and so am in favor of using it for all deps.
Worth mentioning that the caret ( |
@UlisesGascon it's not supported on the npm that comes with node 0.8, but if you use either way, i think it can be fine if you need a newer node to install it as long as it works in old node (albeit, not ideal) |
So we need to prepare the CI for the packages that still support [email protected] before making any changes to the dependencies |
Yes, for any package that isn't already declaring engines, the first step should be testing (manual or automated) to determine on which versions it's already working - because those are the engines that it's non-breaking to declare. |
@expressjs/express-tc, the way forward is to update the CI, or do we prefer to do this in a major version when support for Node.js 0.8 is removed? |
I think the suggestions are mostly agreed upon, @UlisesGascon if you want to make these I can change my review to approved and we can merge this right? (or if you want I can merge them and do it myself, just didn't want to step on your toes) The rest of the questions/comments dont seem applicable now right? |
Ref: expressjs/compression#214 (comment) I don't think we should make the CI more complicated by applying this change to packages we have not rev'd to drop node versions. I think it is better to do nothing to those until we have another reason to major rev them. |
Im in favor of caret being the default for all deps, external or not. AKA I want to accept the suggestions to change the proposal to state that. |
Co-authored-by: Chris de Almeida <[email protected]>
Co-authored-by: Wes Todd <[email protected]>
Co-authored-by: Wes Todd <[email protected]>
Co-authored-by: Wes Todd <[email protected]>
Co-authored-by: Wes Todd <[email protected]>
Co-authored-by: Wes Todd <[email protected]>
Co-authored-by: Wes Todd <[email protected]>
Co-authored-by: Wes Todd <[email protected]>
Policy on using caret (
^
) or tilde (~
) with dependencies^
) or tilde (~
) for dependencies that we maintain while avoiding its use for third-party dependencies.Context
^
) with our own dependencies #279