Ignoring fields with struct tag expr:"-" and make "in" return false for unexported fields #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegommm
commented
Jun 24, 2025
| @@ -139,7 +140,71 @@ func ExampleEnv_tagged_field_names() { | |||
|
|
|||
| fmt.Printf("%v", output) | |||
|
|
|||
| // Output : Hello World | |||
There was a problem hiding this comment.
This is unrelated but I realized that this example test was not being run because there is a space between Output and :, so I removed the space and the example test is now running and is successful.
diegommm
commented
Jun 24, 2025
Comment on lines
-532
to
+597
| // Output : Hello, you, world! | ||
| // Output: Hello, you, world! |
There was a problem hiding this comment.
Same as above: this is unrelated but I realized that this example test was not being run because there is a space between Output and :, so I removed the space and the example test is now running and is successful.
antonmedv
reviewed
Jun 25, 2025
antonmedv
reviewed
Jun 25, 2025
antonmedv
reviewed
Jun 25, 2025
antonmedv
reviewed
Jun 25, 2025
antonmedv
reviewed
Jun 25, 2025
diegommm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805 and #807