This repository was archived by the owner on Jan 18, 2024. It is now read-only.
Updated webpack-config #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed web polyfills * Udpated index.html style * Use primaryColor for msapplication navbutton-color * Moved WebpackDeepScopeAnalysisPlugin to common * Removed vendoring * Added support for `.otf` fonts * Removed custom optimization in favor of webpack defaults * Removed terser
fson
approved these changes
Mar 8, 2019
| } | ||
|
|
||
| const publicPath = '/'; | ||
| const publicPath = ''.replace(/\/$/, ''); |
There was a problem hiding this comment.
This is just an empty string '', is that on purpose?
There was a problem hiding this comment.
We may be adding publicUrl for export right? If so then this will prevent // in the index.html. This looks a little strange out of context because I split it into 2 PRs.
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 11, 2019
Summary: Initially if a `react-native-web` project were to use a library that required internals `expo/webpack-config` would polyfill those internals. This `Platform.web` was used for cases where `react-native` modules needed other internal `react-native` modules, ex: `Animated/src/AnimatedEvent -> Renderer/shims/ReactNative -> Renderer/oss/ReactNativeRenderer-dev -> Core/InitializeCore -> Devtools/setupDevtools -> WebSocket/WebSocket -> Utilities/Platform` The consensus is that if any `react-native` library references a `react-native` internal (ex: `react-native/*`), it should continue to throw errors. We've removed the use of internals from all of the Unimodules, `react-navigation`, and `react-native-gesture-handler`. This covers a wide enough area for a lot of projects to get web support. * Add emitters for libs referencing internals necolas/react-native-web#1275 * Remove monkey patch that bundles RN, libs that use internals will crash instead expo/expo-cli#409 * Remove all unsupported internals and polyfills from the Expo suite expo/expo#3676 * Remove internals from react-native-gesture-handler software-mansion/react-native-gesture-handler#406 * Related #23387 [GENERAL] [REMOVED] - Platform.web.js Pull Request resolved: #23830 Differential Revision: D14406145 Pulled By: hramos fbshipit-source-id: bdda99a334d33f5543fdb954eb80e2e7186f985a
EvanBacon
added a commit
that referenced
this pull request
Mar 12, 2019
* Moved `WebpackDeepScopeAnalysisPlugin` to common * Removed vendoring * Removed custom `optimization` in favor of webpack defaults * Removed `terser-webpack-plugin` * Update yarn.lock * Added web compliation method to XDL * Removed babel-preset-expo * Cleaned up HTML * Added bfj * Fixed copy plugin * Added `expo build:web` * Update index.js * Added `msapplication-navbutton-color` * Added support for `otf` * Moved to #409 * [WIP] * Added build error for web * Added dev flag to build command * Added web error * logging error on build:web * Updated web stats * Removed bfj * Fixed prod builds * Added `excludePolyfill` option to `expo build:web` * Moved web error to XDL * Updated stats promise * excludePolyfill -> no-polyfill * added woff format * packages -> platforms * Removed host option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from #407
.otffonts