Update case studies to pymc v5 #78
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR is a first attempt to update all case studies to the PyMC v5 version of
exoplanet
.Most changes went smoothly, but here are a few things worth noting:
estimate_invers_gamma_parameters()
function had been removed frompymc-ext
. I added it back (see Add backestimate_inverse_gamma_parameters()
in utils pymc-ext#46)observed
argument must be static data and cannot depend on parts of the models.pm.Potential()
. This change is in Support PyMC v5 exoplanet#309mean
argument to the GP. I modified all GPs to be specified in the latter way. I updated the related sigma-clipping and plotting code as well.KeplerianOrbit
issues a warning thatror
should be specified (which I think would require the two instruments to have their own orbit, but with shared parameters exceptror
). The MAP result is also not exactly the same as in PyMC3. The sampling took a couple of hours. Results are again the same as with PyMC3, just much slower.I rarely have to fit light curves, and I'm mostly using Jax recently (though I do like to have PyMC models available as an option), so I don't think I'll have time/interest to dive further into the speed issues, but I think this PR is a good first step to getting all case studies working with PyMC 5.
Thanks!