Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new exercise: pythagorean-triplet #181

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

atk
Copy link
Contributor

@atk atk commented Mar 14, 2025

No description provided.

@atk atk requested a review from keiravillekode March 14, 2025 10:56
@keiravillekode
Copy link
Contributor

keiravillekode commented Mar 14, 2025

minFactor and maxFactor are not part of the problem-specifications specification for this exercise.

JavaScript has added them, and specified then in instructions.append.md

Go has something comparable, but it has its own instructions.append.md, and at least it does not call them factors.

TypeScript added them like JavaScript, but like this PR it omits instructions.append.md

Java and Scala also have them, and neglect to add instructions.append.md

No other track has anything similar for this exercise.

My preference would be to omit minFactor and maxFactor in WASM.

@keiravillekode
Copy link
Contributor

By creating issues like #164 #166 #167, the function signature can be discussed before the exercise is implemented.

import { compileWat, WasmRunner } from "@exercism/wasm-lib";

let wasmModule;
let currentInstance;

beforeAll(async () => {
try {
const watPath = new URL("./.meta/proof.ci.wat", import.meta.url);
const watPath = new URL("./pythagorean-triplet.wat", import.meta.url);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rational-numbers.spec.js and yacht.spec.js will need the same correction here. They also have proof.ci.wat

@keiravillekode keiravillekode merged commit d9e46d4 into exercism:main Mar 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants