Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #301

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Fix CI #301

merged 2 commits into from
Mar 21, 2025

Conversation

keiravillekode
Copy link
Contributor

No description provided.

Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@keiravillekode
Copy link
Contributor Author

CI previously "passed" in 0s

https://github.com/exercism/mips/actions/runs/13996605205/job/39193218652?pr=300

Run ./bin/test test-all
*- Testing all exercises...

*- Testing exercises/practice...
Invalid Command Argument: exercises/practice/runner.mips
Invalid Command Argument: exercises/practice/example.mips

*- Testing exercises/shared...
Invalid Command Argument: exercises/shared/runner.mips
Invalid Command Argument: exercises/shared/example.mips

@glennj
Copy link

glennj commented Mar 21, 2025

Good catch.

Shellcheck has a few things to say about that script, mostly about quoting, including that you can remove eval from line 32

Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Approving but you might want to deal with Glenn's comments before merging :)

@keiravillekode keiravillekode merged commit 93bcbb3 into exercism:main Mar 21, 2025
4 checks passed
@keiravillekode keiravillekode deleted the fix-ci branch March 21, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants