-
-
Notifications
You must be signed in to change notification settings - Fork 72
[Basics] new concept #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Basics] new concept #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One line per sentence per Exercism style guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also my general comments from the lasagna PR also apply to this text where applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introduction.md
is common to this and lasagna
(apart from a couple of lines at the top), so I'll sync changes.
I hope you don't mind I've fixed a small typo, since I figured that was easier than pointing it out. Everything else looks good to me, though. |
Thanks, I saw that earlier and thought I'd fixed it. These things breed and multiply when you're not looking... |
Co-authored-by: András B Nagy <[email protected]>
Co-authored-by: András B Nagy <[email protected]>
Co-authored-by: András B Nagy <[email protected]>
After I lot of confusion, I think this is now what I was aiming for:
Ready to review, I think? If we get this merged, it will then be possible to merge Lasagna. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good to me!
Fantastic, the concept tree now has a root! |
For discussion on the forum.
This concept draft combines and rewrites 3 older concepts. It is paired with the Lasagna concept exercise.