Skip to content

[Basics] new concept #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 4, 2025
Merged

[Basics] new concept #779

merged 11 commits into from
Mar 4, 2025

Conversation

colinleach
Copy link
Contributor

For discussion on the forum.

This concept draft combines and rewrites 3 older concepts. It is paired with the Lasagna concept exercise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line per sentence per Exercism style guide

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also my general comments from the lasagna PR also apply to this text where applicable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The introduction.md is common to this and lasagna (apart from a couple of lines at the top), so I'll sync changes.

@colinleach colinleach changed the title [Basics] new concept exercise [Basics] new concept Sep 9, 2024
@depial
Copy link
Contributor

depial commented Sep 10, 2024

I hope you don't mind I've fixed a small typo, since I figured that was easier than pointing it out. Everything else looks good to me, though.

@colinleach
Copy link
Contributor Author

Thanks, I saw that earlier and thought I'd fixed it. These things breed and multiply when you're not looking...

@colinleach
Copy link
Contributor Author

After I lot of confusion, I think this is now what I was aiming for:

  • introduction.md synced with Lasagna
  • about.md clarified the point of including comments
  • config.json reuses an old UUID from an unwanted concept

Ready to review, I think? If we get this merged, it will then be possible to merge Lasagna.

Copy link
Contributor

@depial depial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me!

@colinleach
Copy link
Contributor Author

Fantastic, the concept tree now has a root!

@colinleach colinleach merged commit 2e252ae into exercism:main Mar 4, 2025
1 check passed
@colinleach colinleach deleted the basics branch March 6, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants