Skip to content

[elyses-enchantments] Concept exercise #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 3, 2025

Conversation

colinleach
Copy link
Contributor

Pairs with the vectors concept.

Content is mostly new, ported from what I previously did for R. The earlier draft in exercises/concept.wip is removed to avoid conflicts.

@colinleach colinleach requested a review from depial March 1, 2025 17:49
@colinleach
Copy link
Contributor Author

Working towards getting a root and a trunk for the start of the syllabus, I think this is where it's at:

Concept Status Exercise Status
basics #779 lasagna #780
booleans merged annelyns-infiltration merged
numbers merged currency-exchange #808
conditionals #799 cars-assemble #832
vectors #802 elyses-enchantmants #833

Of course, there is also a lot of stuff lower down that's making good progress. However, getting to see the start of a coherent syllabus on the Exercism website is becoming a priority for me (you may hear that old people learn patience, but only up to a point).

Copy link
Contributor

@depial depial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be some discrepancy with the naming of some files. Should it be "enchantmants" or "enchantments"? I'm not sure if this was done with some purpose to avoid the old name or not.

Otherwise, there are a couple of small typos in design.md, introduction.md and elyses-enchantmants.jl, which I'll just edit directly.

depial added 3 commits March 3, 2025 16:41
Changes typo "enties" to "entries"
Add missing "of"
Add new line to function definitions
@colinleach
Copy link
Contributor Author

There appears to be some discrepancy with the naming of some files. Should it be "enchantmants" or "enchantments"? I'm not sure if this was done with some purpose to avoid the old name or not.

That was 100% unintended screwup, where my fingers bypassed my brain. It should always be "enchantments".

@colinleach
Copy link
Contributor Author

In case you wondered how I managed to get it wrong in so many different places: I used a Bash script to generate the exercise structure, so once I made a typo on the command line it propagated widely.

Also, it's been a bad few days for config.json issues. I suspect we've not seen the last example of that.

@colinleach
Copy link
Contributor Author

We got there in the end...

@colinleach colinleach merged commit 48f0625 into exercism:main Mar 3, 2025
11 checks passed
@colinleach
Copy link
Contributor Author

I think this is the current top-of-syllabus progress:

Concept Status Exercise Status
basics #779 lasagna merged
booleans merged annalyns-infiltration merged
numbers merged currency-exchange #808
conditionals merged cars-assemble merged
vectors merged elyses-enchantmants merged
ranges draft #803 chessboard #835
vector-operations draft #819 bird-watcher wip

That gives us 3 boxes on Exercism, with 3 more well advanced.

I'm partway through implementing bird-watcher (I decided I prefer this to elyses-analytic-enchantments).

I also found my 80%-complete draft of the strings concept, which will be another important node on the syllabus. Now I just need to figure out what I was intending to write, before I got ill.

@colinleach colinleach deleted the elyses-enchantments branch March 3, 2025 22:37
@depial
Copy link
Contributor

depial commented Mar 3, 2025

I think this is the current top-of-syllabus progress:

Looking good! I'll try to keep reviewing, so we can keep moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants