Add Docker smoke tests #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
force-pushed
the
docker-smoke-tests
branch
from
225bbb4 to
7637fa2
Compare
ErikSchierboom
force-pushed
the
docker-smoke-tests
branch
3 times, most recently
from
4efdf46 to
415fe21
Compare
|
@SleeplessByte I'm gonna go ahead and merge this as I feel that it is really important to have Docker-based smoke tests for the JavaScript test runner. If you'd like me to change things let me know. |
|
@ErikSchierboom that's fine! I trust youuuuu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow for running the smoke tests within a Docker environment. This reduces the likelihood of CI passing even though the actual Docker image does not work as intended.
There already were smoke tests, but I couldn't get them to run inside the Docker image (permissions issues). I thus opted for an hybrid approach, where the existing smoke tests are augmented with an
expected_results.jsonfile.If successful, we then know that: