Skip to content

ENH: edited russian translate "By" #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

askras
Copy link
Contributor

@askras askras commented Jan 5, 2024

No description provided.

Copy link

welcome bot commented Jan 5, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@agoose77
Copy link
Collaborator

agoose77 commented Mar 4, 2024

@askras does this translation make sense if you remove the trailing colon?

@askras
Copy link
Contributor Author

askras commented Mar 4, 2024

@askras does this translation make sense if you remove the trailing colon?

Good afternoon!

If you remove the colon, the meaning remains. But with a colon it’s more correct

@askras
Copy link
Contributor Author

askras commented Mar 7, 2024

Perhaps it is even better to use an empty string as a translation ". Then everyone will be able to use their own format of the author's description.

@agoose77 agoose77 merged commit 4e30b06 into executablebooks:master Nov 25, 2024
2 checks passed
@agoose77 agoose77 changed the title Edited russian translate "By" FIX: edited russian translate "By" Feb 20, 2025
@agoose77 agoose77 changed the title FIX: edited russian translate "By" ENH: edited russian translate "By" Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants