Skip to content

Add project URLs to pyproject.toml #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

Add project URLs to pyproject.toml #631

merged 1 commit into from
Nov 9, 2022

Conversation

rkdarst
Copy link
Contributor

@rkdarst rkdarst commented Oct 30, 2022

  • Were missing (but in the readme), adding should be self-explanatory.
  • These would have saved me a few seconds, so I may as well add them.
  • Review: I'm not entirely sure if these are the common names in
    executablebooks.

@rkdarst
pyproject.toml: Add project URLs
d5a0143 
- Were missing (but in the readme), adding should be self-explanatory.
@welcome
Copy link

welcome bot commented Oct 30, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

choldgraf
choldgraf approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks for noticing and making the improvement!

@choldgraf choldgraf changed the title pyproject.toml: Add project URLs Add project URLs to pyproject.toml Nov 9, 2022
@choldgraf choldgraf merged commit 591c70b into executablebooks:master Nov 9, 2022
@welcome
Copy link

welcome bot commented Nov 9, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkdarst @choldgraf