Skip to content

Bump the version of pytest for compatibility with python 3.10 #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

ZedThree
Copy link
Contributor

@ZedThree ZedThree commented Oct 7, 2022

Pytest 6.2.5 is the first version that supports python 3.10: https://pytest.org/en/latest/changelog.html#pytest-6-2-5-2021-08-29

@welcome
Copy link

welcome bot commented Oct 7, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@AakashGfude
Copy link
Member

Hi @ZedThree, I would suggest bump the version of pytest more, and pytest-cov as well. Like here: https://github.com/executablebooks/MyST-NB/blob/master/pyproject.toml#L103

@ZedThree
Copy link
Contributor Author

Should I bump myst-nb version at the same time?

* master:
  [pre-commit.ci] pre-commit autoupdate (executablebooks#621)
  🐛 FIX: Correcting a broken link in CHANGELOG.md (executablebooks#623)
@AakashGfude
Copy link
Member

@ZedThree, we will do that in a separate PR. It needs some additional testing.

@AakashGfude AakashGfude merged commit 5c6f03e into executablebooks:master Oct 19, 2022
@welcome
Copy link

welcome bot commented Oct 19, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@ZedThree ZedThree deleted the bump-pytest-py3.10 branch October 19, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants