Skip to content

Add skip to main content link #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

andesol
Copy link

@andesol andesol commented Sep 28, 2022

Add a simple jump to main content link on top of the page (only visible when you first press tab) so users can skip the left navigation

image

@welcome
Copy link

welcome bot commented Sep 28, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

Could you provide some more information about what you mean by "skip the left navigation"? That should all be hidden by default. Is this for screen readers and accessibility purposes?

@chrisjsewell
Copy link
Member

It's this @choldgraf https://youtu.be/VUR0I5mqq7I

@choldgraf
Copy link
Member

So this one has actually now been implemented in the upstream theme (pydata-sphinx-theme):

I think that we can close this PR since we'll inherit this feature from the upstream, though we should double-check that it is in-fact inherited

many thanks @andesol for surfacing this issue and providing an implementation - I think that the person in the pydata theme used it for inspiration there

@choldgraf
Copy link
Member

I'm gonna close this one as we now have an implementation we'll inherit from the pydata theme!

Here's the PR where this was merged upstream:

And here's the PR that should bring this in, assuming that a PyData theme release is made before it is merged:

@choldgraf choldgraf closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants