-
Notifications
You must be signed in to change notification settings - Fork 205
Update pydata theme to 0.10 #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 24 commits
8ab4c61
fec749a
9e9ca0b
d617024
e8aef57
3fdc6ea
f483810
7cab01f
9b4a7f1
e26498d
910e808
f04e20f
7400de8
8bead42
4b25376
84dadff
6394af5
df06dbe
c7c7be8
5ad3a12
97cbe13
cbac680
8906812
8342f63
ef5c9e1
b00c966
7c093aa
9031b2b
1f56581
82a7467
6c60479
4c4a092
7d446cc
9f1a7a6
7933831
e38e18e
d55232c
1185d8f
fda71f2
b7abf67
e88c122
bae766d
0592a1c
6b2a1d1
cad8a51
0ef5512
adade87
2493713
fff2b7f
16553ee
bb90d7b
34d850f
cb84124
4674e96
492062b
95ab90e
089cef7
32216bd
cda1e3d
3e56239
562f122
80a2694
eb30e64
bf32d10
341f5d6
107ca0e
45c9967
e60d56d
393c13d
abfc613
2409962
71100c0
eb58dcf
5962068
e4f52ba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,7 +56,7 @@ var toggleFullScreen = () => { | |
* the screen. | ||
*/ | ||
var scrollToActive = () => { | ||
var navbar = document.getElementById("site-navigation"); | ||
var navbar = document.getElementsByClassName("bd-sidebar-primary")[0]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that we should be able to delete the whole scrolltoactive section, since that code exists in the pydata theme: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how is it supposed to work again? the primary sidebar should scroll automatically if the active page is off-screen right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @choldgraf I checked using master, and this doesn't seem to be working #609 . Did it work for you? |
||
var active_pages = navbar.querySelectorAll(".active"); | ||
var active_page = active_pages[active_pages.length - 1]; | ||
// Only scroll the navbar if the active link is lower than 50% of the page | ||
|
@@ -116,9 +116,9 @@ var initTocHide = () => { | |
|
||
// Hide the TOC if any margin content is displayed on the screen | ||
if (onScreenItems.length > 0) { | ||
$("div.bd-toc").removeClass("show"); | ||
$("div.bd-sidebar-secondary").removeClass("show"); | ||
} else { | ||
$("div.bd-toc").addClass("show"); | ||
$("div.bd-sidebar-secondary").addClass("show"); | ||
} | ||
}; | ||
let manageScrolledClassOnBody = (entries, observer) => { | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd try rc2 - that makes some more changes