Skip to content

Make the topbar configurable with the PyData theme topbar code #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
choldgraf opened this issue May 10, 2021 · 0 comments · Fixed by #677
Closed
3 tasks

Make the topbar configurable with the PyData theme topbar code #334

choldgraf opened this issue May 10, 2021 · 0 comments · Fixed by #677
Labels
enhancement New feature or request 🏷️ templating Related to the Jinja templating

Comments

@choldgraf
Copy link
Member

The PyData theme recently updated its topbar code so that it can be configured with these three options:

...
"navbar_start": [list-of-templates],
"navbar_center": [list-of-templates],
"navbar_end": [list-of-templates],
...

That logic is here: https://github.com/pydata/pydata-sphinx-theme/blob/master/pydata_sphinx_theme/docs-navbar.html

We could populate our topbar using the same template logic, so that we're re-using the configurability mechanism. This could let people configure the topbar in similar ways.

Tasks

  • Should we rename navbar to topbar and then translate into the PyData theme config name of "navbar"?
  • Swap out our topbar code with the configurable pydata sphinx theme options
  • Tests passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🏷️ templating Related to the Jinja templating
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant