-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate tests to vitest #3381
base: main
Are you sure you want to change the base?
Conversation
Deploying excaliburjs with
|
Latest commit: |
009c0e7
|
Status: | ✅ Deploy successful! |
Preview URL: | https://24d375c4.excaliburjs.pages.dev |
Branch Preview URL: | https://chore-vitest.excaliburjs.pages.dev |
@eonarheim at long last the tests are passing. let me know what you think of how i handled the TextSpec tests. Also IIRC this still lacks the memory tracking and other custom karma reporting stuff. would you want that done in this PR? (oh and we still need to test that the browserstack karma tests still run... seems like the workflow for that only runs on commits to the main branch) |
managed to migrate the engine leak & memory reporters, although it took a bit of rigamarole. Mainly because, as opposed to karma, the reporter runs in node and not the browser. So I have to track the data needed separately in some global hooks within the browser environment, which the reporter then reads and creates the logs if needed. However, it seems the memory tracking is regularly reporting >1 mb, so I'm not sure if it's tracking properly or if things have changed with the new browsers. My only theory is that because the timing where memory is read is during an Implementation is done in |
TODO:
===:clipboard: PR Checklist :clipboard:===
==================
Closes #
Changes: