A few questions regarding contribution #2372
Replies: 2 comments 10 replies
-
|
@mattjennings These are great questions, sorry for the struggles
|
Beta Was this translation helpful? Give feedback.
-
|
@mattjennings Give this branch a shot when you get a chance #2373 |
Beta Was this translation helpful? Give feedback.
-
|
This looks interesting as well, vscode integrated development environments with containers https://code.visualstudio.com/docs/remote/containers |
Beta Was this translation helpful? Give feedback.
-
|
@eonarheim Ahh thanks for getting that docker branch up quickly. I had to update the docker-compose to specify the architechture like so: version: '3'
services:
dev:
platform: linux/x86_64
build:
context: .
dockerfile: docker/Dockerfile
working_dir: /opt/app
container_name: 'dev'
volumes:
- './:/opt/app'
- /opt/app/node_modulesbut unfortunately it seems Chrome headless fails to start with a nasty error I'll see if I can get this working at all tomorrow, don't worry about spending too much time on it! |
Beta Was this translation helpful? Give feedback.
-
|
Shouldn't the platform on the M1 be ARM64 theoretically? |
Beta Was this translation helpful? Give feedback.
-
|
That's what I had thought too, but without specifying platform it couldn't install google-chrome-stable while building the container. However I did also try specifying This seems to be a known puppeteer issue, but the suggested fixes of adding |
Beta Was this translation helpful? Give feedback.
-
|
Oh it looks like chrome isn't packaged for arm64, that might explain a few
things...
https://askubuntu.com/questions/1383789/install-chrome-on-ubuntu-debian-with-arm64
We might be able to get away with chromium, I don't think we leverage
anything truly chrome specific.
…On Wed, Jun 29, 2022 at 9:29 AM Matt Jennings ***@***.***> wrote:
That's what I had thought too, but without specifying platform it couldn't
install google-chrome-stable
<puppeteer/puppeteer#7752> while building the
container. However I did also try specifying platform: linux/amd64 and
that built too, but still has the same error when running the tests.
This seems to be a known puppeteer issue
<puppeteer/puppeteer#7746>, but the suggested
fixes of adding --single-process and --disable-gpu to the puppeteer
config in karma (the latter of which was already there) didn't work. I'll
keep digging, but I might just resign to a Linux VM at this point :P
—
Reply to this email directly, view it on GitHub
<#2372 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEVNZ7MKGDQRX4WEZENNQTVRRMVXANCNFSM52EB45DQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
@eonarheim I was able to get all tests passing in macOS on M1 by using Chromium instead of Chrome, so if that works for you then that's certainly the best solution for me! I'll submit a PR with the changes shortly |
Beta Was this translation helpful? Give feedback.
-
|
see #2374 |
Beta Was this translation helpful? Give feedback.
-
|
@mattjennings Excellent! Thanks for digging in! |
Beta Was this translation helpful? Give feedback.
-
|
Can confirm that the test suite now also passes in Linux with Chromium 🥳 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I have a few questions relating to contribution and the state of the repo, as I've started working away at #1548.
Some of these may warrant their own issues, but for now just dumping it all here for discussion!
npm run test). I'm using a Macbook with M1 so I have a feeling that's why, as these are passing on CI. Do you know if anyone has tried running them on M1 before? Majority of them are WebGL errors, like this:Is prettier enforced by anything? I ran
npm run prettierand it updated 233 files. It also then causednpm run lintto fail (conflicting rules)The
.vscode/settings.jsoneslint config needs an update, as the eslint vscode extension pops this up every character I type 😅I'm happy to make individual PRs to address at least the linting side of things. As for the tests, that one seems rather complicated if it is M1 related 😞
Beta Was this translation helpful? Give feedback.
All reactions