👷 Add GitHub Actions config #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardodino
commented
Jun 22, 2021
| @@ -76,7 +79,16 @@ | |||
| ], | |||
| "rules": { | |||
| "prettier/prettier": 2, | |||
| "no-shadow": 2 | |||
There was a problem hiding this comment.
this one is incompatible with typescript, the equivalent is already included:
see: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-shadow.md
exah
reviewed
Jul 7, 2021
| const scope = nock('http://localhost') | ||
| .get('/comments') | ||
| .reply(200) | ||
| const scope = nock('http://localhost').get('/comments').reply(200) |
There was a problem hiding this comment.
I don't understand why formatting is changed here. Are your editor correctly picks up the project's .prettierrc.js?
There was a problem hiding this comment.
Hmm.. look like the issue indeed on my side. Ignore the comment :D
exah
approved these changes
Jul 7, 2021
|
<3 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only did prettier auto-fix, had to disable a few rules from
eslint-config-standard-with-typescript,otherwise it ends up butchering the code 😅 during auto-fix.
we can cleanup manually later on, but at least now we don't regress 😄