Use go tool to trace tool dependencies #255
Conversation
Makefile
Outdated
| @@ -6,6 +6,15 @@ BASE_STACK = docker compose -f docker-compose.yml | |||
| INTEGRATION_TEST_STACK = $(BASE_STACK) -f docker-compose-integration-test.yml | |||
| ALL_STACK = $(INTEGRATION_TEST_STACK) | |||
|
|
|||
| # go tool | |||
| GCI = go tool github.com/daixiang0/gci | |||
There was a problem hiding this comment.
Wow, why so complex? Now I can't use it like simple cmd from terminal?
There was a problem hiding this comment.
Sure, you can use the go install tool command to install these tools into GOBIN.
Hmm, it does seem a bit too complicated—I think that's because this feature was newly released.
There was a problem hiding this comment.
So, we should use this installation command, I guess. It may help us to get a better experience with pure command line usages and Makefile usages. What do you think about this?
yshngg
force-pushed
the
feature/go-tool
branch
2 times, most recently
from
ef8e3e1 to
4d3c7bc
Compare
|
@yshngg, this branch has conflicts. Could you rebase/fix your branch? |
… and using direct calls This commit removes the unnecessary Go tool variables and directly uses the tool commands, streamlining the Makefile and reducing maintenance overhead.
Hi @soltanoff , I have already successfully resolved the conflict. |
|
@yshngg looks good, thank you |
Track tool dependencies using commands such as
go get -tool golang.org/x/tools/cmd/stringerandgo tool golang.org/x/tools/cmd/stringer.Currently, the
migratetool does not integrate properly with the newgo toolfeature released in Go 1.24.Fix #237