Skip to content

Generic partitioning DSL #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

galvana
Copy link
Contributor

@galvana galvana commented May 29, 2025

Closes []

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 30, 2025 4:08pm
fides-privacy-center ⬜️ Ignored (Inspect) May 30, 2025 4:08pm

Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 78.46154% with 28 lines in your changes missing coverage. Please review.

Project coverage is 87.02%. Comparing base (c844f2a) to head (c8dd3db).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/schemas/partitioning.py 84.34% 13 Missing and 5 partials ⚠️
src/fides/api/graph/config.py 36.36% 3 Missing and 4 partials ⚠️
.../connectors/query_configs/bigquery_query_config.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6182      +/-   ##
==========================================
- Coverage   87.06%   87.02%   -0.05%     
==========================================
  Files         422      423       +1     
  Lines       26208    26335     +127     
  Branches     2853     2872      +19     
==========================================
+ Hits        22817    22917     +100     
- Misses       2769     2787      +18     
- Partials      622      631       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant