Skip to content

Adding certifi to fix SSL CA Error #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2025
Merged

Conversation

Vagoasdf
Copy link
Contributor

@Vagoasdf Vagoasdf commented May 9, 2025

Closes LJ-728

Description Of Changes

We were having trouble hitting Shopify subdomains recently, with the integration returning an SSL Error of an invalid CA.
We confirmed that from the server, we were able to access those endpoints, so it was a problem with Fides not getting the Certificates correctly.

This should point which certificates to use directly.

Code Changes

  • Using Certifi to get the proper CA

Steps to Confirm

  1. DSRs where we had problems with SSL should pass

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 3:58pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 12, 2025 3:58pm

@@ -5,6 +5,7 @@ anyio==3.7.1
APScheduler==3.9.1.post1
asyncpg==0.27.0
boto3==1.26.1
certifi==2024.8.30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vagoasdf is there a reason we're not using the latest?

Copy link
Contributor Author

@Vagoasdf Vagoasdf May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was compatible with Requests 2.32.3 which i believe is the one we are currently running (throught FastAPI)

Im not saying the latest wasn't compatible, but that this was the one that was bundled up directly, and just in case im going for the safer option in case something was changed between then and now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the explanation!

Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.60%. Comparing base (2c90dd8) to head (65b8bd3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6139   +/-   ##
=======================================
  Coverage   86.60%   86.60%           
=======================================
  Files         423      423           
  Lines       26148    26150    +2     
  Branches     2840     2840           
=======================================
+ Hits        22645    22648    +3     
  Misses       2890     2890           
+ Partials      613      612    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Vagoasdf Vagoasdf merged commit 7014c01 into main May 12, 2025
39 of 40 checks passed
@Vagoasdf Vagoasdf deleted the LJ-728-SSL-CA-Not-Recognized branch May 12, 2025 19:38
Copy link

cypress bot commented May 12, 2025

fides    Run #12921

Run Properties:  status check passed Passed #12921  •  git commit 7014c01aa7: Adding certifi to fix SSL CA Error (#6139)
Project fides
Branch Review main
Run status status check passed Passed #12921
Run duration 00m 51s
Commit git commit 7014c01aa7: Adding certifi to fix SSL CA Error (#6139)
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants