-
Notifications
You must be signed in to change notification settings - Fork 81
Adding certifi to fix SSL CA Error #6139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@@ -5,6 +5,7 @@ anyio==3.7.1 | |||
APScheduler==3.9.1.post1 | |||
asyncpg==0.27.0 | |||
boto3==1.26.1 | |||
certifi==2024.8.30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vagoasdf is there a reason we're not using the latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was compatible with Requests 2.32.3
which i believe is the one we are currently running (throught FastAPI)
Im not saying the latest wasn't compatible, but that this was the one that was bundled up directly, and just in case im going for the safer option in case something was changed between then and now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks for the explanation!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6139 +/- ##
=======================================
Coverage 86.60% 86.60%
=======================================
Files 423 423
Lines 26148 26150 +2
Branches 2840 2840
=======================================
+ Hits 22645 22648 +3
Misses 2890 2890
+ Partials 613 612 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 51s |
Commit |
|
Committer | Bruno Gutierrez Rios |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Closes LJ-728
Description Of Changes
We were having trouble hitting Shopify subdomains recently, with the integration returning an SSL Error of an invalid CA.
We confirmed that from the server, we were able to access those endpoints, so it was a problem with Fides not getting the Certificates correctly.
This should point which certificates to use directly.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works