Skip to content

HA-676 - Fixed a bug that prevented from showing all the integrations… #6138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2025
Merged

HA-676 - Fixed a bug that prevented from showing all the integrations… #6138

merged 4 commits into from
May 9, 2025

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented May 9, 2025 •
edited by jira bot
Loading

Closes HA-676

Description Of Changes

Fixed a bug that prevented from showing all the integrations when on the system page

Code Changes

  • Added support for multiple pages on when pulling /connection_type list

Steps to Confirm

  1. All the integrations should be available
  2. The dev console should show at least two API calls with pagination params attached to them

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented May 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 6:58pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 9, 2025 6:58pm

tvandort
tvandort reviewed May 9, 2025
View reviewed changes
clients/admin-ui/src/features/connection-type/connection-type.slice.ts Outdated
url: `${CONNECTION_TYPE_ROUTE}${mapFiltersToSearchParams({
...filters,
page: i + 2,
size: 100,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably assign 100 to a const and reuse it in both places.

Also I understand why we use 2 here but I'd like to see it in a variable that explains that in the name so I can shut my brain off while reading.

@andres-torres-marroquin andres-torres-marroquin merged commit bdbb5b3 into main May 9, 2025
16 of 17 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HA-676 branch May 9, 2025 19:01
andres-torres-marroquin added a commit that referenced this pull request May 9, 2025
@andres-torres-marroquin
HA-676 - Fixed a bug that prevented from showing all the integrations… (
76c9a00 
#6138)
@cypress Cypress
Copy link

cypress bot commented May 9, 2025

fides    Run #12919

Run Properties:  status check passed Passed #12919  •  git commit bdbb5b3007: HA-676 - Fixed a bug that prevented from showing all the integrations… (#6138)
Project fides
Branch Review main
Run status status check passed Passed #12919
Run duration 00m 52s
Commit git commit bdbb5b3007: HA-676 - Fixed a bug that prevented from showing all the integrations… (#6138)
Committer Andrés Torres Marroquín
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvandort tvandort tvandort left review comments

@jpople jpople jpople approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andres-torres-marroquin @jpople @tvandort