Skip to content

Andres/ha 642 #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 9, 2025
Merged

Andres/ha 642 #6137

merged 8 commits into from
May 9, 2025

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented May 9, 2025 •
edited by jira bot
Loading

Closes HA-642

Description Of Changes

Adding use of oktaMonitor flag for hidding Identity Provider tab on Integrations UI

Code Changes

  • Updated clients/admin-ui/src/features/integrations/useIntegrationFilterTabs.tsx

Steps to Confirm

  1. Use the feature flag to show/hide the IDP tab on integrations UI

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented May 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 4:29pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 4:29pm

@andres-torres-marroquin andres-torres-marroquin merged commit 4b728c9 into main May 9, 2025
17 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HA-642 branch May 9, 2025 16:44
andres-torres-marroquin added a commit that referenced this pull request May 9, 2025
@andres-torres-marroquin
Andres/ha 642 (#6137)
40035a7
@cypress Cypress
Copy link

cypress bot commented May 9, 2025

fides    Run #12916

Run Properties:  status check passed Passed #12916  •  git commit 4b728c9f13: Andres/ha 642 (#6137)
Project fides
Branch Review main
Run status status check passed Passed #12916
Run duration 00m 54s
Commit git commit 4b728c9f13: Andres/ha 642 (#6137)
Committer Andrés Torres Marroquín
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpople jpople jpople approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @jpople