Skip to content

LJ-747 - Allow Reserved Keywords for MySQL connections #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

wadesdev
Copy link
Contributor

@wadesdev wadesdev commented Apr 28, 2025

Closes LJ-747

Description Of Changes

Allows MySQL integration to complete Helios D&D steps for a DB using keywords in columns.

Code Changes

  • MySQLConfig updates generate_raw_query to add backticks to fields

Steps to Confirm

  1. A MySQL DB using reserved keywords as column names can successfully complete Helios D&D

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 10:30pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 10:30pm

@wadesdev wadesdev requested a review from adamsachs April 28, 2025 19:17
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.85%. Comparing base (a57a57c) to head (c04c05a).

Files with missing lines Patch % Lines
.../connectors/query_configs/bigquery_query_config.py 0.00% 3 Missing ⚠️
...ice/connectors/query_configs/mysql_query_config.py 0.00% 3 Missing ⚠️
.../connectors/query_configs/redshift_query_config.py 0.00% 2 Missing ⚠️
...connectors/query_configs/snowflake_query_config.py 0.00% 2 Missing ⚠️
...i/service/connectors/query_configs/query_config.py 80.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (42.10%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (84.85%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6095      +/-   ##
==========================================
- Coverage   86.92%   84.85%   -2.07%     
==========================================
  Files         423      423              
  Lines       26150    26154       +4     
  Branches     2840     2840              
==========================================
- Hits        22730    22193     -537     
- Misses       2800     3338     +538     
- Partials      620      623       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wadesdev wadesdev changed the title Fides 1926 HA-669 - Allow Reserved Keywords for MySQL connections May 6, 2025
@wadesdev wadesdev changed the title HA-669 - Allow Reserved Keywords for MySQL connections LJ-747 - Allow Reserved Keywords for MySQL connections May 6, 2025
@@ -8,21 +8,26 @@ dataset:
- system.operations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to revert the changes to this file and the .fides/ directory in general

Copy link
Contributor Author

@wadesdev wadesdev May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thingscouldbeworse for sure, I'm just fumbling with git

This reverts commit ac8bd8d.

	modified:   tests/fixtures/mysql_fixtures.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants