-
Notifications
You must be signed in to change notification settings - Fork 81
LJ-747 - Allow Reserved Keywords for MySQL connections #6095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/fides/api/service/connectors/query_configs/mysql_query_config.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (42.10%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6095 +/- ##
==========================================
- Coverage 86.92% 84.85% -2.07%
==========================================
Files 423 423
Lines 26150 26154 +4
Branches 2840 2840
==========================================
- Hits 22730 22193 -537
- Misses 2800 3338 +538
- Partials 620 623 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.fides/db_dataset.yml
Outdated
@@ -8,21 +8,26 @@ dataset: | |||
- system.operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to revert the changes to this file and the .fides/
directory in general
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thingscouldbeworse for sure, I'm just fumbling with git
This reverts commit ac8bd8d. modified: tests/fixtures/mysql_fixtures.py
Closes LJ-747
Description Of Changes
Allows MySQL integration to complete Helios D&D steps for a DB using keywords in columns.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works