Skip to content

3632 clickable system tiles #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 6, 2023
Merged

3632 clickable system tiles #3734

merged 17 commits into from
Jul 6, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 5, 2023

Closes #3632

Description Of Changes

Makes system cards on "view systems" page clickable and link to that system's configure/[id] page.

Steps to Confirm

  • Go to "view systems" page
  • Click on a system's box in the grid

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jul 5, 2023

Passing run #3061 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge d665daa into 3add450...
Project: fides Commit: 3e50421399 ℹ️
Status: Passed Duration: 00:58 💡
Started: Jul 6, 2023 3:23 PM Ended: Jul 6, 2023 3:24 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jpople jpople requested a review from allisonking July 5, 2023 14:15
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it's nice to be able to click directly on the card 😄 I think we should try implementing this through links though, let me know what you think?

also, this would be a good opportunity to add a cypress test!

@jpople jpople requested a review from allisonking July 6, 2023 15:25
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 nice work!

@jpople jpople merged commit c4640a8 into main Jul 6, 2023
@jpople jpople deleted the 3632-clickable-system-tiles branch July 6, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tiles clickable in View Systems page
2 participants