Skip to content

Render linebreaks in the Fides.js overlay descriptions, etc. #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Jun 23, 2023

Description Of Changes

Often, we're going to want to use line breaks to break up paragraphs of legalese in the overlays - adding whitespace: pre-line allows the browser to do this without any fancy rich text components 👍

For example, if I use a string like this:

We use cookies and similar methods to recognize visitors and remember their preferences.

We also use them to measure ad campaign effectiveness, target ads and analyze site traffic. Learn more about these methods, including how to manage them, by clicking ‘Manage Preferences.’ By clicking ‘accept’ you consent to the of these methods by us and our third parties. By clicking ‘reject’ you decline the use of these methods.",

Compare:

Before (whitespace: normal) After (whitespace: pre-line)
image image

Code Changes

  • Update fides.css styles

Steps to Confirm

  • Run turbo build for the fides-js project and open the clients/privacy-center/public/fides-js-components-demo.html page

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Jun 23, 2023

Passing run #2887 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge de5263e into b4f1b3b...
Project: fides Commit: f54b69cade ℹ️
Status: Passed Duration: 01:06 💡
Started: Jun 23, 2023 5:17 PM Ended: Jun 23, 2023 5:18 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@NevilleS NevilleS merged commit d8cd3d7 into main Jun 23, 2023
@NevilleS NevilleS deleted the ns-fides-js-support-line-breaks branch June 23, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants