-
Notifications
You must be signed in to change notification settings - Fork 81
Adding array support for unflatten_dict #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Passing run #2968 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3629 +/- ##
===========================================
+ Coverage 48.72% 87.09% +38.36%
===========================================
Files 310 310
Lines 19052 19042 -10
Branches 2439 2441 +2
===========================================
+ Hits 9284 16585 +7301
+ Misses 9604 2028 -7576
- Partials 164 429 +265
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, tricky change! but great test coverage, the tests make clear the behavior of the change and confirms it's working on a number of different edge cases.
i still have trouble fully tracking all the flattened dict transformations that come thru with the masking engine codepath, so i just want to confirm that we're not going to hit an edge case here where an integer-like string, e.g. "0"
or "1"
, is actually intended to be a dict key? rather than an indicator of the index of the element in the list as we're assuming/treating it now.
Closes #3493
Description Of Changes
This ticket updates the
unflatten_dict
function to be able to "unflatten" array valuesCode Changes
unflatten_dict
function and updated the test casesPre-Merge Checklist
CHANGELOG.md