Fix AWS Scan Test

[ThomasLaPiana]

Closes #

Newly-created test resources: https://ethyca.atlassian.net/browse/OPS-346?focusedCommentId=36117

Code Changes

• Update the expected objects for the AWS system scan test
• Update Secrets for the actions

Steps to Confirm

• ctl-external tests pass

Pre-Merge Checklist

• All CI Pipelines Succeeded

Description Of Changes

Update the expected resources within our external tests to match the reality of what actually exists in those accounts.

Additionally, @daveqnet has created a sequestered area for our tests so that we shouldn't have to worry about resource drift/changes impacting these tests in the future.

[cypress]

Passing run #2903 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge e49522c into c55abb0...
Project: fides	Commit: b6f69a5757 ℹ️
Status: Passed	Duration: 01:06 💡
Started: Jun 26, 2023 11:17 AM	Ended: Jun 26, 2023 11:18 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (c55abb0) 87.10% compared to head (e49522c) 87.10%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3556   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files         310      310           
  Lines       19031    19031           
  Branches     2437     2437           
=======================================
  Hits        16577    16577           
  Misses       2026     2026           
  Partials      428      428           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ThomasLaPiana]

fyi @daveqnet I'm going to fix this here

[daveqnet]

fyi @daveqnet I'm going to fix this here

Gotcha! The thing we'll need to work on is IAM and which creds/secrets are being used by this test in CI. I wasn't able to puzzle this out from the code - do you know?

[edit: obviously just looking for their parameter names in GH Actions secrets, not the actual secret values]

[ThomasLaPiana]

fyi @daveqnet I'm going to fix this here

Gotcha! The thing we'll need to work on is IAM and which creds/secrets are being used by this test in CI. I wasn't able to puzzle this out from the code - do you know?

[edit: obviously just looking for their parameter names in GH Actions secrets, not the actual secret values]

I'm not sure how to figure that out either 🤔 if it isn't obvious maybe we should just create new creds for this test env specifically?

[daveqnet]

I'm not sure how to figure that out either 🤔 if it isn't obvious maybe we should just create new creds for this test env specifically?

Okay, yep, let's do it, @ThomasLaPiana. I will message you privately to discuss.

[adamsachs]

thank you @ThomasLaPiana and @daveqnet for the diligence in clearing this up! 🎊

CI failures for external saas tests seem unrelated, though we do have to clean that up at some point. not relevant here though!

[SteveDMurphy]

CI failures for external saas tests seem unrelated, though we do have to clean that up at some point. not relevant here though!

We created this #3278 recently as well for saas connectors too @adamsachs - agree hopefully soon!

[ThomasLaPiana]

thank you all! team effort here 🙂