Skip to content

Add psc-ide-server arguments and pass src to psc-ide-server #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2017

Conversation

kozak
Copy link
Contributor

@kozak kozak commented Jan 6, 2017

Should fix:
#79

For me this is also required for psc-ide-vim to work with the psc-ide-server instance started by purs-loader.

@ethul
Copy link
Owner

ethul commented Jan 7, 2017

Thanks for the PR. I think the addition of the server args is a good one. However, I am wondering if we should not add the src globs by default since it is mentioned in #79 that doing this adds lag. Perhaps we can allow the user to configure it if desired.

@kritzcreek
Copy link

Just so you know, only the initial load command is affected. Rebuilding shouldn't be any slower.

@ethul
Copy link
Owner

ethul commented Jan 8, 2017

Thanks for the info @kritzcreek. Out of curiosity, on a large project, would it be a noticeable delay during load?

@chexxor
Copy link

chexxor commented Jan 8, 2017 via email

@kozak
Copy link
Contributor Author

kozak commented Jan 9, 2017

You could also override the globs by passing {"_": []} as pscIdeServerArgs

@ethul
Copy link
Owner

ethul commented Jan 9, 2017

Good points all. @kozak I think that makes sense. Perhaps it would be worth adding your comment as a note in the README. Would you be okay to add this to your PR?

@kozak
Copy link
Contributor Author

kozak commented Jan 9, 2017

Done.

@ethul
Copy link
Owner

ethul commented Jan 9, 2017

Looks great. Thanks!

@ethul ethul merged commit 941d65a into ethul:master Jan 9, 2017
@chexxor
Copy link

chexxor commented Jan 9, 2017

Thanks @kozak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants