Topic/psc ide #77
Merged
Topic/psc ide #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The objective of enabling psc-ide is to obtain feedback immediately from the PureScript compiler. When the loader triggers an error to webpack, the bundle is invalidated and dependencies of the PureScript file that caused the error will be passed through the loader on the next successful rebuild. However, this behaviour adds time to the feedback loop. In order to reduce the time of the PureScript compiler feedback loop when in development, this commit always resolves the rebuild process with a success. Errors and warnings are still emitted, but the webpack bundle is not invalidated. This means that the loader will only be run for the current file being editted and the developer gets immediate feedback on success or failure when psc-ide is enabled. Resolves #76
Instead of forcing a recompile on an unknown value and on unknown module imports, opt to only recompile for unknown module imports. An unknown value may be a typo. Having a faster feedback loop in these cases seems ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.