-
Notifications
You must be signed in to change notification settings - Fork 3
chore: Switch examples Typescript Execution Engine from ts-node to tsx [skip ci] #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Yooo! You forgot to bump the version in package.json! |
Yooo! You forgot to bump the version in package.json! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.circleci/config.yml (1)
3-5
: Review Parameter Default ChangeThe default value of the
run_e2e_tests
parameter has been changed fromtrue
tofalse
. This effectively disables the E2E tests by default in the pipeline. Please ensure that this behavior is documented and that developers know how to override it when E2E tests should run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yooo! You forgot to bump the version in package.json! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
ts-node
totsx
Types of changes
What types of changes does your code introduce?
Typescript Execution Engine
Further comments (optional)
Summary by CodeRabbit
Summary by CodeRabbit