This repository was archived by the owner on Oct 30, 2024. It is now read-only.
V0 Removing hdkey native dependency. #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @holgerd77, This PR is just a backport of #128. The reason this is needed is cause #128 landed in a new major version, so it would take a long time before the entire ecosystem receives the update. Can we release v0.6.5 with this fix? |
alcuadrado
approved these changes
Jun 30, 2020
|
@nebojsa94 this PR is not building on top of the latest state of the v0.6.x. Can you please update here (via rebase)? |
nebojsa94
force-pushed
the
v0-removing-native-js-dependencies
branch
from
af0afbe to
83b2cab
Compare
|
@holgerd77 Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes hdkey dependency and instead uses ethereum-cryptography package that doesn't require native dependency compiling.