Do not use named function labels if function names are not unique. #12139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
nonamedlabelsifnotunique
branch
from
8ae7765 to
f0c9a0d
Compare
cameel
reviewed
Oct 14, 2021
| @@ -0,0 +1 @@ | |||
| --strict-assembly | |||
There was a problem hiding this comment.
I don't think the annotations add much in this particular test. Might actually be more readable without them. Maybe it would be better to disable them?
Suggested change
| --strict-assembly | |
| --strict-assembly --debug-info none |
|
Does this PR fix also a similar case I found in inline assembly #12090 (comment)? EDIT: Reported as a separate issue (#12158). |
cameel
reviewed
Oct 18, 2021
| @@ -0,0 +1 @@ | |||
| --experimental-via-ir --combined-json function-debug-runtime | |||
There was a problem hiding this comment.
Output would be more readable if it was not all on a single line:
Suggested change
| --experimental-via-ir --combined-json function-debug-runtime | |
| --experimental-via-ir --combined-json function-debug-runtime --pretty-json --json-indent 4 |
Comment on lines
1
to
8
| contract C { | ||
| function f() public pure returns (uint r) { | ||
| assembly { function f() -> x { x := 1 } r := f() } | ||
| } | ||
| function g() public pure returns (uint r) { | ||
| assembly { function f() -> x { x := 2 } r := f() } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| contract C { | |
| function f() public pure returns (uint r) { | |
| assembly { function f() -> x { x := 1 } r := f() } | |
| } | |
| function g() public pure returns (uint r) { | |
| assembly { function f() -> x { x := 2 } r := f() } | |
| } | |
| } | |
| contract C { | |
| function f() public pure returns (uint r) { | |
| assembly { function f() -> x { x := 1 } r := f() } | |
| } | |
| function g() public pure returns (uint r) { | |
| assembly { function f() -> x { x := 2 } r := f() } | |
| } | |
| } |
Also in function_name_clash.sol below.
Comment on lines
+1
to
+8
| contract C { | ||
| function f() public pure returns (uint r) { | ||
| assembly { function f() -> x { x := 1 } r := f() } | ||
| } | ||
| function g() public pure returns (uint r) { | ||
| assembly { function f() -> x { x := 2 } r := f() } | ||
| } | ||
| } |
|
Incorporated #12149 into the test. |
cameel
previously approved these changes
Oct 19, 2021
chriseth
force-pushed
the
nonamedlabelsifnotunique
branch
from
346a850 to
9f48b74
Compare
|
Rebased, simplified commandline tests and updated the "fixes". |
cameel
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12090
Fixes #12149
Fixes #12158