Skip to content

accounts/abi: simulator implements interface PendingStateReader #28438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 30, 2023

Implement the first interface mentioned in #28431

Signed-off-by: jsvisa <[email protected]>
@s1na
Copy link
Contributor

s1na commented Oct 30, 2023

I know I raised the ticket you are fixing but my goal was to discuss it first:

  • One argument for not adding these to simulated backend is that there's a rough consensus that we will drop the pending state from geth. Which means these methods will have to be removed possibly soon after they are added.
  • Also people can omit the PendingStateReader from the interface and they would be able to switch between ethclient and simulated backend seemlessly.

My opinion is it's fine to add these methods until we remove pending state. Open to hear other opinions.

@fjl fjl closed this Dec 5, 2023
@fjl
Copy link
Contributor

fjl commented Dec 5, 2023

Closing because we have another PR that rewrites the simulated backend based on ethclient. That version will have the methods automatically.

@fjl
Copy link
Contributor

fjl commented Dec 5, 2023

This is the PR: #28202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants