eth/downloader: fix unexpected skeleton header deletion #26451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26300
This PR fixes a scenario in which Geth will delete referenced skeleton header by mistake.
In the example listed in #26300
325@0946fa
327@e97873
These two headers are in different chain, reorg happens. Geth syncs up the missing skeleton
headers which links up with local chain. The link point is lower than
325
.Then there is a special logic in beacon sync that
And if the associated header of leftover subchain is in range of
new subchain(just like the example), we delete the skeleton header
referenced by new subchain by mistake because we don't check
the hash at all.
Please check #26300 for more information.
Thanks @holiman for detailed analysis!