This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fix/GitHub tests #1087
Merged
Fix/GitHub tests #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalinin
suggested changes
May 30, 2018
| @@ -74,10 +81,9 @@ | |||
|
|
|||
| public static String loadJSONFromCommit(String filename, String shacommit) throws IOException { | |||
| String json = ""; | |||
| if (!SystemProperties.getDefault().githubTestsLoadLocal()) | |||
| json = getFromUrl("https://raw.githubusercontent.com/ethereum/tests/" + shacommit + "/" + filename); | |||
| json = getFromUrl("https://raw.githubusercontent.com/ethereum/tests/" + shacommit + "/" + filename); | |||
There was a problem hiding this comment.
This change makes it impossible to read tests from local folder
There was a problem hiding this comment.
I'd suggest to have a 3rd option like GitHubTests.useDiskCache
|
@mkalinin how about such approach? |
|
The incentive behind storing it in the config is to avoid frequent updates of |
|
@mkalinin review me, plz |
mkalinin
suggested changes
Jun 1, 2018
| throw ex | ||
| } | ||
| } | ||
| } |
| # to determinate commit of Ethereum tests repo https://github.com/ethereum/tests | ||
| # which should be checked out in local repo directory | ||
| # EthereumJ is tested with files from this commit | ||
| GitHubTests.commit=7f638829311dfc1d341c1db85d8a891f57fa4da7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache made with properties file and storing downloaded files. According to log it's used on travis instead of download. We could try this solution. What do you think?