Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Issue #1078 Gradle Task to create executable fatJar #1080

Merged
merged 1 commit into from
May 22, 2018
Merged

Issue #1078 Gradle Task to create executable fatJar #1080

merged 1 commit into from
May 22, 2018

Conversation

kishansagathiya
Copy link
Contributor

@kishansagathiya kishansagathiya commented May 21, 2018

This commit adds a gradle task which will create an executable jar
with all the dependencies

Fixes #1078

@kishansagathiya
Copy link
Contributor Author

@mkalinin
I was able to create an executable jar without using a dependency like Shadow.
Eventhough, I have raised this PR, I have a feeling that you either don't want a task to create executable jar( because you removed shadowJar). In which case, feel free to close this.
Any reason for removing shadowJar? Does this PR help?

@coveralls
Copy link

coveralls commented May 21, 2018

Coverage Status

Coverage decreased (-0.1%) to 55.91% when pulling b01c4ac on kishansagathiya:issue_1078 into bb0d8b6 on ethereum:develop.

Copy link
Collaborator

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we've removed shadowJar plugin because it was conflicting with our main build. Your approach looks functioning but I'm not sure it will keep working after changing some dependencies. Anyway it works now and let's keep it!

README.md Outdated
./gradlew clean shadowJar
java -jar ethereumj-core/build/libs/ethereumj-core-*-all.jar
./gradlew clean fatJar
java -jar ethereumj-core/build/libs/ethereumj-core-*-fat.jar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep all in filename, it's more common

This commit adds a gradle task which will create an executable jar
with all the dependencies
@zilm13 zilm13 merged commit a9c5fca into ethereum:develop May 22, 2018
@zilm13
Copy link
Collaborator

zilm13 commented May 22, 2018

@kishansagathiya No need to do everything in one commit next time. It's better to see changes in separate commit according to review and not a big deal if we have 2+ commits for one pr.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants