Skip to content

Link to TDS blog post #15816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Link to TDS blog post #15816

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5310ad1
include link to TDS blog post
pettinarip Jul 12, 2025
98062dd
fix: remove isolated href from intl strings
wackerow Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions app/[locale]/trillion-dollar-security/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
CardDescription,
CardFooter,
} from "@/components/ui/card"
import { BaseLink as Link } from "@/components/ui/Link"
import InlineLink, { BaseLink as Link } from "@/components/ui/Link"

import { getMetadata } from "@/lib/utils/metadata"

Expand Down Expand Up @@ -104,7 +104,19 @@ const TdsPage = async ({ params }: { params: Promise<{ locale: Lang }> }) => {
/>
</div>

<p>{t("page-trillion-dollar-security-hero-paragraph-5")}</p>
<p>
{t.rich("page-trillion-dollar-security-hero-paragraph-5", {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Hadn't figured this out yet, but this solves the server-side htmr challenges, and also allows us to inject any variable this way using variations of a <span></span>.

a: (chunks) => (
<InlineLink
href={t(
"page-trillion-dollar-security-hero-paragraph-5-link"
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
href={t(
"page-trillion-dollar-security-hero-paragraph-5-link"
)}
href="https://blog.ethereum.org/2025/05/14/trillion-dollar-security"

Any reason we can't place the link directly in here? No need for the link to be translated

>
{chunks}
</InlineLink>
),
})}
</p>
<p>{t("page-trillion-dollar-security-hero-paragraph-6")}</p>

<ol className="list-decimal font-bold text-primary">
Expand Down
3 changes: 2 additions & 1 deletion src/intl/en/page-trillion-dollar-security.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"page-trillion-dollar-security-hero-paragraph-2": "But for Ethereum to succeed in the next phase of global adoption, there are still many improvements that must be made. To achieve our community's ambitions, Ethereum must grow into an ecosystem where:",
"page-trillion-dollar-security-hero-paragraph-3": "Billions of individuals are each comfortable holding more than $1000 onchain, collectively amounting to trillions of dollars secured on Ethereum.",
"page-trillion-dollar-security-hero-paragraph-4": "Companies, institutions, and governments are comfortable storing more than 1 trillion dollars of value inside a single contract or application, and are comfortable transacting in comparable amounts.",
"page-trillion-dollar-security-hero-paragraph-5": "The Trillion Dollar Security (1TS) project is an ecosystem-wide effort to upgrade Ethereum's security. This report is the first deliverable of the 1TS project. Over the last month, we have gathered feedback from users, developers, security experts, and institutions about where they see the biggest challenges and areas for improvement. Thank you to the hundreds of people and dozens of organizations who have taken the time to share your insights with us.",
"page-trillion-dollar-security-hero-paragraph-5": "The <a>Trillion Dollar Security (1TS)</a> project is an ecosystem-wide effort to upgrade Ethereum's security. This report is the first deliverable of the 1TS project. Over the last month, we have gathered feedback from users, developers, security experts, and institutions about where they see the biggest challenges and areas for improvement. Thank you to the hundreds of people and dozens of organizations who have taken the time to share your insights with us.",
"page-trillion-dollar-security-hero-paragraph-5-link": "https://blog.ethereum.org/2025/05/14/trillion-dollar-security",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"page-trillion-dollar-security-hero-paragraph-5-link": "https://blog.ethereum.org/2025/05/14/trillion-dollar-security",

"page-trillion-dollar-security-hero-paragraph-6": "This report summarizes our findings, covering 6 distinct areas:",
"page-trillion-dollar-security-report-card-title": "Ethereum ecosystem security overview report",
"page-trillion-dollar-security-download-report": "Download PDF",
Expand Down